The apt::source resource defaults the parameter notify_update to
true. All other resources in the module do not explicitly specify
notify_update, so it stands out that it is set to its default
here. This commit removes the explicit setting to make the freeswith
repository consistent with the others and not unnecessarily attract
the attention of a future reader inexperienced with puppet.
The package apt-transport-https is required to successfully add some
of the debian repos. This commit moves the package resource
installation into the rhizo_base::apt::debian class instead of the
rhizo_base:📦:debian class to break a dependency cycle that
would otherwise exist if rhizo_base::apt::debian depended on all of
rhizo_base:📦:debian.
Puppet treats included classes specially, and does not assume that
they are contained in their outside class for the sake of dependency
ordering. This means that any other resources requiring the base
non-distribution specific classes were actually not capturing the
ordering dependencies on resources defined in the distribution
specific class!
