Added puppetlabs-firewall (required by puppetlabs-postgresql), updated the other modules.

modules/firewall/spec/unit/facter/iptables_persistent_version_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+describe "Facter::Util::Fact iptables_persistent_version" do
+  before { Facter.clear }
+  let(:dpkg_cmd) { "dpkg-query -Wf '${Version}' iptables-persistent 2>/dev/null" }
+
+  {
+    "Debian" => "0.0.20090701",
+    "Ubuntu" => "0.5.3ubuntu2",
+  }.each do |os, ver|
+    describe "#{os} package installed" do
+      before {
+        allow(Facter.fact(:operatingsystem)).to receive(:value).and_return(os)
+        allow(Facter::Util::Resolution).to receive(:exec).with(dpkg_cmd).
+          and_return(ver)
+      }
+      it { Facter.fact(:iptables_persistent_version).value.should == ver }
+    end
+  end
+
+  describe 'Ubuntu package not installed' do
+    before {
+      allow(Facter.fact(:operatingsystem)).to receive(:value).and_return('Ubuntu')
+      allow(Facter::Util::Resolution).to receive(:exec).with(dpkg_cmd).
+        and_return(nil)
+    }
+    it { Facter.fact(:iptables_persistent_version).value.should be_nil }
+  end
+
+  describe 'CentOS not supported' do
+    before { allow(Facter.fact(:operatingsystem)).to receive(:value).
+               and_return("CentOS") }
+    it { Facter.fact(:iptables_persistent_version).value.should be_nil }
+  end
+end

modules/firewall/spec/unit/facter/iptables_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe "Facter::Util::Fact" do
+  before {
+    Facter.clear
+    allow(Facter.fact(:kernel)).to receive(:value).and_return('Linux')
+    allow(Facter.fact(:kernelrelease)).to receive(:value).and_return('2.6')
+  }
+
+  describe 'iptables_version' do
+    it {
+      allow(Facter::Util::Resolution).to receive(:exec).with('iptables --version').
+      and_return('iptables v1.4.7')
+      Facter.fact(:iptables_version).value.should == '1.4.7'
+    }
+  end
+
+  describe 'ip6tables_version' do
+    before { allow(Facter::Util::Resolution).to receive(:exec).
+             with('ip6tables --version').and_return('ip6tables v1.4.7') }
+    it { Facter.fact(:ip6tables_version).value.should == '1.4.7' }
+  end
+end