Added modules

modules/ntp/spec/acceptance/class_spec.rb

@@ -0,0 +1,37 @@
+require 'spec_helper_acceptance'
+
+describe 'ntp class:', :unless => UNSUPPORTED_PLATFORMS.include?(fact('osfamily')) do
+  it 'should run successfully' do
+    pp = "class { 'ntp': }"
+
+    # Apply twice to ensure no errors the second time.
+    apply_manifest(pp, :catch_failures => true) do |r|
+      expect(r.stderr).not_to match(/error/i)
+    end
+    apply_manifest(pp, :catch_failures => true) do |r|
+      expect(r.stderr).not_to eq(/error/i)
+
+      expect(r.exit_code).to be_zero
+    end
+  end
+
+  context 'service_ensure => stopped:' do
+    it 'runs successfully' do
+      pp = "class { 'ntp': service_ensure => stopped }"
+
+      apply_manifest(pp, :catch_failures => true) do |r|
+        expect(r.stderr).not_to match(/error/i)
+      end
+    end
+  end
+
+  context 'service_ensure => running:' do
+    it 'runs successfully' do
+      pp = "class { 'ntp': service_ensure => running }"
+
+      apply_manifest(pp, :catch_failures => true) do |r|
+        expect(r.stderr).not_to match(/error/i)
+      end
+    end
+  end
+end

modules/ntp/spec/acceptance/disable_monitoring_spec.rb

@@ -0,0 +1,30 @@
+require 'spec_helper_acceptance'
+
+describe "ntp class with disable_monitor:", :unless => UNSUPPORTED_PLATFORMS.include?(fact('osfamily')) do
+  context 'should run successfully' do
+    pp = "class { 'ntp': disable_monitor => true }"
+
+    it 'runs twice' do
+      apply_manifest(pp, :catch_failures => true)
+      apply_manifest(pp, :catch_changes => true)
+    end
+
+    describe file('/etc/ntp.conf') do
+      it { should contain('disable monitor') }
+    end
+  end
+
+  context 'should run successfully' do
+    pp = "class { 'ntp': disable_monitor => false }"
+
+    it 'runs twice' do
+      apply_manifest(pp, :catch_failures => true)
+      apply_manifest(pp, :catch_changes => true)
+    end
+
+    describe file('/etc/ntp.conf') do
+      it { should_not contain('disable monitor') }
+    end
+  end
+
+end

modules/ntp/spec/acceptance/nodesets/centos-64-x64-pe.yml

@@ -0,0 +1,12 @@
+HOSTS:
+  centos-64-x64:
+    roles:
+      - master
+      - database
+      - dashboard
+    platform: el-6-x86_64
+    box : centos-64-x64-vbox4210-nocm
+    box_url : http://puppet-vagrant-boxes.puppetlabs.com/centos-64-x64-vbox4210-nocm.box
+    hypervisor : vagrant
+CONFIG:
+  type: pe

modules/ntp/spec/acceptance/nodesets/centos-64-x64.yml

@@ -0,0 +1,10 @@
+HOSTS:
+  centos-64-x64:
+    roles:
+      - master
+    platform: el-6-x86_64
+    box : centos-64-x64-vbox4210-nocm
+    box_url : http://puppet-vagrant-boxes.puppetlabs.com/centos-64-x64-vbox4210-nocm.box
+    hypervisor : vagrant
+CONFIG:
+  type: foss

modules/ntp/spec/acceptance/nodesets/centos-65-x64.yml

@@ -0,0 +1,10 @@
+HOSTS:
+  centos-65-x64:
+    roles:
+      - master
+    platform: el-6-x86_64
+    box : centos-65-x64-vbox436-nocm
+    box_url : http://puppet-vagrant-boxes.puppetlabs.com/centos-65-x64-virtualbox-nocm.box
+    hypervisor : vagrant
+CONFIG:
+  type: foss

modules/ntp/spec/acceptance/nodesets/default.yml

@@ -0,0 +1,10 @@
+HOSTS:
+  centos-64-x64:
+    roles:
+      - master
+    platform: el-6-x86_64
+    box : centos-64-x64-vbox4210-nocm
+    box_url : http://puppet-vagrant-boxes.puppetlabs.com/centos-64-x64-vbox4210-nocm.box
+    hypervisor : vagrant
+CONFIG:
+  type: foss

modules/ntp/spec/acceptance/nodesets/fedora-18-x64.yml

@@ -0,0 +1,10 @@
+HOSTS:
+  fedora-18-x64:
+    roles:
+      - master
+    platform: fedora-18-x86_64
+    box : fedora-18-x64-vbox4210-nocm
+    box_url : http://puppet-vagrant-boxes.puppetlabs.com/fedora-18-x64-vbox4210-nocm.box
+    hypervisor : vagrant
+CONFIG:
+  type: foss

modules/ntp/spec/acceptance/nodesets/sles-11-x64.yml

@@ -0,0 +1,10 @@
+HOSTS:
+  sles-11-x64.local:
+    roles:
+      - master
+    platform: sles-11-x64
+    box : sles-11sp1-x64-vbox4210-nocm
+    box_url : http://puppet-vagrant-boxes.puppetlabs.com/sles-11sp1-x64-vbox4210-nocm.box
+    hypervisor : vagrant
+CONFIG:
+    type: foss

modules/ntp/spec/acceptance/nodesets/ubuntu-server-10044-x64.yml

@@ -0,0 +1,10 @@
+HOSTS:
+  ubuntu-server-10044-x64:
+    roles:
+      - master
+    platform: ubuntu-10.04-amd64
+    box : ubuntu-server-10044-x64-vbox4210-nocm
+    box_url : http://puppet-vagrant-boxes.puppetlabs.com/ubuntu-server-10044-x64-vbox4210-nocm.box
+    hypervisor : vagrant
+CONFIG:
+  type: foss

modules/ntp/spec/acceptance/nodesets/ubuntu-server-12042-x64.yml

@@ -0,0 +1,10 @@
+HOSTS:
+  ubuntu-server-12042-x64:
+    roles:
+      - master
+    platform: ubuntu-12.04-amd64
+    box : ubuntu-server-12042-x64-vbox4210-nocm
+    box_url : http://puppet-vagrant-boxes.puppetlabs.com/ubuntu-server-12042-x64-vbox4210-nocm.box
+    hypervisor : vagrant
+CONFIG:
+  type: foss

modules/ntp/spec/acceptance/ntp_config_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper_acceptance'
+
+case fact('osfamily')
+when 'FreeBSD'
+  line = '0.freebsd.pool.ntp.org iburst maxpoll 9'
+when 'Debian'
+  line = '0.debian.pool.ntp.org iburst'
+when 'RedHat'
+  line = '0.centos.pool.ntp.org'
+when 'SuSE'
+  line = '0.opensuse.pool.ntp.org'
+when 'Gentoo'
+  line = '0.gentoo.pool.ntp.org'
+when 'Linux'
+  case fact('operatingsystem')
+  when 'ArchLinux'
+    line = '0.pool.ntp.org'
+  when 'Gentoo'
+    line = '0.gentoo.pool.ntp.org'
+  end
+when 'AIX'
+  line = '0.debian.pool.ntp.org iburst'
+end
+
+describe 'ntp::config class', :unless => UNSUPPORTED_PLATFORMS.include?(fact('osfamily')) do
+  it 'sets up ntp.conf' do
+    apply_manifest(%{
+      class { 'ntp': }
+    }, :catch_failures => true)
+  end
+
+  describe file('/etc/ntp.conf') do
+    it { should be_file }
+    it { should contain line }
+  end
+end

modules/ntp/spec/acceptance/ntp_install_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper_acceptance'
+
+case fact('osfamily')
+when 'FreeBSD'
+  packagename = 'net/ntp'
+when 'Gentoo'
+  packagename = 'net-misc/ntp'
+when 'Linux'
+  case fact('operatingsystem')
+  when 'ArchLinux'
+    packagename = 'ntp'
+  when 'Gentoo'
+    packagename = 'net-misc/ntp'
+  end
+when 'AIX'
+  packagename = 'bos.net.tcp.client'
+else
+  packagename = 'ntp'
+end
+
+describe 'ntp::install class', :unless => UNSUPPORTED_PLATFORMS.include?(fact('osfamily')) do
+  it 'installs the package' do
+    apply_manifest(%{
+      class { 'ntp': }
+    }, :catch_failures => true)
+  end
+
+  describe package(packagename) do
+    it { should be_installed }
+  end
+end

modules/ntp/spec/acceptance/ntp_parameters_spec.rb

@@ -0,0 +1,165 @@
+require 'spec_helper_acceptance'
+
+case fact('osfamily')
+when 'FreeBSD'
+  packagename = 'net/ntp'
+when 'Gentoo'
+  packagename = 'net-misc/ntp'
+when 'Linux'
+  case fact('operatingsystem')
+  when 'ArchLinux'
+    packagename = 'ntp'
+  when 'Gentoo'
+    packagename = 'net-misc/ntp'
+  end
+when 'AIX'
+  packagename = 'bos.net.tcp.client'
+else
+  packagename = 'ntp'
+end
+
+describe "ntp class:", :unless => UNSUPPORTED_PLATFORMS.include?(fact('osfamily')) do
+  it 'applies successfully' do
+    pp = "class { 'ntp': }"
+
+    apply_manifest(pp, :catch_failures => true) do |r|
+      expect(r.stderr).not_to match(/error/i)
+    end
+  end
+
+  describe 'autoconfig' do
+    it 'raises a deprecation warning' do
+      pp = "class { 'ntp': autoupdate => true }"
+
+      apply_manifest(pp, :catch_failures => true) do |r|
+        expect(r.stdout).to match(/autoupdate parameter has been deprecated and replaced with package_ensure/)
+      end
+    end
+  end
+
+  describe 'config' do
+    it 'sets the ntp.conf location' do
+      pp = "class { 'ntp': config => '/etc/antp.conf' }"
+      apply_manifest(pp, :catch_failures => true)
+    end
+
+    describe file('/etc/antp.conf') do
+      it { should be_file }
+    end
+  end
+
+  describe 'config_template' do
+    it 'sets up template' do
+      modulepath = default['distmoduledir']
+      shell("mkdir -p #{modulepath}/test/templates")
+      shell("echo 'testcontent' >> #{modulepath}/test/templates/ntp.conf")
+    end
+
+    it 'sets the ntp.conf location' do
+      pp = "class { 'ntp': config_template => 'test/ntp.conf' }"
+      apply_manifest(pp, :catch_failures => true)
+    end
+
+    describe file('/etc/ntp.conf') do
+      it { should be_file }
+      it { should contain 'testcontent' }
+    end
+  end
+
+  describe 'driftfile' do
+    it 'sets the driftfile location' do
+      pp = "class { 'ntp': driftfile => '/tmp/driftfile' }"
+      apply_manifest(pp, :catch_failures => true)
+    end
+
+    describe file('/etc/ntp.conf') do
+      it { should be_file }
+      it { should contain 'driftfile /tmp/driftfile' }
+    end
+  end
+
+  describe 'keys' do
+    it 'enables the key parameters' do
+      pp = <<-EOS
+      class { 'ntp':
+        keys_enable     => true,
+        keys_file       => '/etc/ntp/keys',
+        keys_controlkey => '/etc/ntp/controlkey',
+        keys_requestkey => '1',
+        keys_trusted    => [ '1', '2' ],
+      }
+      EOS
+      # Rely on a shell command instead of a file{} here to avoid loops
+      # within puppet when it tries to manage /etc/ntp/keys before /etc/ntp.
+      shell("mkdir -p /etc/ntp && echo '1 M AAAABBBB' >> /etc/ntp/keys")
+      apply_manifest(pp, :catch_failures => true)
+    end
+
+    describe file('/etc/ntp.conf') do
+      it { should be_file }
+      it { should contain 'keys /etc/ntp/keys' }
+      it { should contain 'controlkey /etc/ntp/controlkey' }
+      it { should contain 'requestkey 1' }
+      it { should contain 'trustedkey 1 2' }
+    end
+  end
+
+  describe 'package' do
+    it 'installs the right package' do
+      pp = <<-EOS
+      class { 'ntp':
+        package_ensure => present,
+        package_name   => ['#{packagename}'],
+      }
+      EOS
+      apply_manifest(pp, :catch_failures => true)
+    end
+
+    describe package(packagename) do
+      it { should be_installed }
+    end
+  end
+
+  describe 'panic => false' do
+    it 'enables the tinker panic setting' do
+      pp = <<-EOS
+      class { 'ntp':
+        panic => false,
+      }
+      EOS
+      apply_manifest(pp, :catch_failures => true)
+    end
+
+    describe file('/etc/ntp.conf') do
+      it { should contain 'tinker panic' }
+    end
+  end
+
+  describe 'panic => true' do
+    it 'disables the tinker panic setting' do
+      pp = <<-EOS
+      class { 'ntp':
+        panic => true,
+      }
+      EOS
+      apply_manifest(pp, :catch_failures => true)
+    end
+
+    describe file('/etc/ntp.conf') do
+      it { should_not contain 'tinker panic 0' }
+    end
+  end
+
+  describe 'udlc' do
+    it 'adds a udlc' do
+      pp = "class { 'ntp': udlc => true }"
+      apply_manifest(pp, :catch_failures => true)
+    end
+
+    describe file('/etc/ntp.conf') do
+      it { should be_file }
+      it { should contain '127.127.1.0' }
+    end
+  end
+
+end

modules/ntp/spec/acceptance/ntp_service_spec.rb

@@ -0,0 +1,63 @@
+require 'spec_helper_acceptance'
+
+case fact('osfamily')
+when 'RedHat', 'FreeBSD', 'Linux', 'Gentoo'
+  servicename = 'ntpd'
+when 'AIX'
+  servicename = 'xntpd'
+else
+  servicename = 'ntp'
+end
+
+describe 'ntp::service class', :unless => UNSUPPORTED_PLATFORMS.include?(fact('osfamily')) do
+  describe 'basic test' do
+    it 'sets up the service' do
+      apply_manifest(%{
+        class { 'ntp': }
+      }, :catch_failures => true)
+    end
+
+    describe service(servicename) do
+      it { should be_enabled }
+      it { should be_running }
+    end
+  end
+
+  describe 'service parameters' do
+    it 'starts the service' do
+      pp = <<-EOS
+      class { 'ntp':
+        service_enable => true,
+        service_ensure => running,
+        service_manage => true,
+        service_name   => '#{servicename}'
+      }
+      EOS
+      apply_manifest(pp, :catch_failures => true)
+    end
+
+    describe service(servicename) do
+      it { should be_running }
+      it { should be_enabled }
+    end
+  end
+
+  describe 'service is unmanaged' do
+    it 'shouldnt stop the service' do
+      pp = <<-EOS
+      class { 'ntp':
+        service_enable => false,
+        service_ensure => stopped,
+        service_manage => false,
+        service_name   => '#{servicename}'
+      }
+      EOS
+      apply_manifest(pp, :catch_failures => true)
+    end
+
+    describe service(servicename) do
+      it { should be_running }
+      it { should be_enabled }
+    end
+  end
+end

modules/ntp/spec/acceptance/preferred_servers_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper_acceptance'
+
+describe 'preferred servers', :unless => UNSUPPORTED_PLATFORMS.include?(fact('osfamily')) do
+  pp = <<-EOS
+      class { '::ntp':
+        servers           => ['a', 'b', 'c', 'd'],
+        preferred_servers => ['c', 'd'],
+      }
+  EOS
+
+  it 'applies cleanly' do
+    apply_manifest(pp, :catch_failures => true) do |r|
+      expect(r.stderr).not_to match(/error/i)
+    end
+  end
+
+  describe file('/etc/ntp.conf') do
+    it { should be_file }
+    it { should contain 'server a' }
+    it { should contain 'server b' }
+    it { should contain 'server c prefer' }
+    it { should contain 'server d prefer' }
+  end
+end

modules/ntp/spec/acceptance/restrict_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper_acceptance'
+
+describe "ntp class with restrict:", :unless => UNSUPPORTED_PLATFORMS.include?(fact('osfamily')) do
+  context 'should run successfully' do
+    pp = "class { 'ntp': restrict => ['test restrict']}"
+
+    it 'runs twice' do
+      2.times do
+        apply_manifest(pp, :catch_failures => true) do |r|
+          expect(r.stderr).not_to match(/error/i)
+        end
+      end
+    end
+  end
+
+  describe file('/etc/ntp.conf') do
+    it { should contain('test restrict') }
+  end
+
+end

modules/ntp/spec/acceptance/unsupported_spec.rb

@@ -0,0 +1,10 @@
+require 'spec_helper_acceptance'
+
+describe 'unsupported distributions and OSes', :if => UNSUPPORTED_PLATFORMS.include?(fact('osfamily')) do
+  it 'should fail' do
+    pp = <<-EOS
+    class { 'ntp': }
+    EOS
+    expect(apply_manifest(pp, :expect_failures => true).stderr).to match(/is not supported on an/i)
+  end
+end